Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

The article is actually really useful; it’s a good example of how to not think of code reviews. If you relate to any of the text except for the last three lines, it means you’re reflecting on and running code reviews wrong.

A code review is an opportunity for the reviewer to learn about someone else’s coding style and improve it when necessary, and the reviewee to learn their flaws and just how other people see their code. Because everyone has their own viewpoint with their own flaws. Not an opportunity for the code reviewer to show that he’s smarter, or the reviewee to be “humiliated” that his code isn’t perfect.



This is the epitome of taking good from things even-though you know it is total garbage. ;)




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: